fix: add finish_reason processing to xai.ts provider #9929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same fix as roo.ts and openrouter.ts - process finish_reason during streaming to emit tool_call_end events immediately, ensuring tool calls are finalized without waiting for [DONE] stream termination signal.
dosubot
bot
added
size:M
Contributor
Review complete. No issues found. The implementation correctly adds Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
Issue - Needs Approval
mrubens
approved these changes
Dec 9, 2025
github-project-automation
bot
moved this from Issue [Needs Approval]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #9927 - same fix applied to the xAI provider.
When using native tool calling, if an API returns
finish_reason: "tool_calls"but delays or fails to send the[DONE]stream termination signal, the stream would hang indefinitely waiting for tool calls to be finalized.Fix
This PR:
NativeToolCallParserinxai.tsfinishReasonfromchunk.choices[0]?.finish_reasonfinish_reasonduring streaming to immediately emittool_call_endeventsfinish_reasonis received, without waiting for[DONE]Testing
xai.tsto verifytool_call_endevents are emitted whenfinish_reason: "tool_calls"is receivedImportant
Fixes stream hanging issue in
xai.tsby processingfinish_reasonto emittool_call_endevents immediately.xai.ts, capturesfinishReasonfromchunk.choices[0]?.finish_reasonand processes it to emittool_call_endevents immediately.[DONE]signal.xai.spec.tsto verifytool_call_endevents are emitted whenfinish_reason: "tool_calls"is received.This description was created by
for 6c2f4bb. You can customize this summary. It will automatically update as commits are pushed.